Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: installation command for tls plugin #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipankardas011
Copy link

Explanation

as the existing installtion command lead to missing link
refering to https://github.com/second-state/http_req#build-and-run

Related issue

What type of PR is this

/kind bug

Proposed Changes

replaced the URL of binary with working one

Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
Copy link
Collaborator

alabulei1 commented Jun 14, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 1659873b916f968579af6115870afe5c7770ccf6

Key changes:

  • Updated the openssl-based TLS plugin installation command for WasmEdge.
  • Replaced the old rustls-based plugin download link with an HTTPS request plugin tarball download link.

Potential problems:

  • There are no obvious problems with this patch.
  • It is difficult to detect hidden potential problems without further details about the specific project. The reviewer should ensure that the changes made in the patch are relevant, correct, and consistent with the project's goals.

@dipankardas011
Copy link
Author

@alabulei1 @juntao

@alabulei1
Copy link
Collaborator

Hi @dipankardas011

Thanks for pointing this out. We use rust-tls plugin to replace the wasmedge_httpsreq plugin. So I think the existing docs are right.

@dipankardas011
Copy link
Author

dipankardas011 commented Jul 3, 2023

Hi @dipankardas011

Thanks for pointing this out. We use rust-tls plugin to replace the wasmedge_httpsreq plugin. So I think the existing docs are right.

can you review the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants